theforeman/puppet-puppet

11.0.0 Changelog missing breaking extlib upgrade

Closed this issue · 5 comments

The 11.0.0 changelog lists the extlib changes as enhancement, but due to the higher version of extlib now required, this is a breaking change.

I’ll add a PR for this tomorrow.

ekohl commented

So you consider #639 a breaking change? Not entirely sure what semver says about minimal version dependencies.

On a quick scan, I didn’t find anything about how to deal with dependencies, however #639 broke compatibility with extlib < 3.0.0.

Personally, I’d consider this a breaking change and would deal with those „dependency breaking changes“ as with an API breaking change.

I’ll also read through this thoroughly in semver tomorrow.

ekohl commented

Did you find anything? I can change the changelog but wondering what the best practices are here.

I did not find anything in regards to this in semver, but I would consider it a breaking change as it will break for some systems that were supported before.

ekohl commented

This was fixed in the 11.0.1 changelog.