thegeeklab/hugo-geekdoc

Columns within tabs get rendered as Code blocks

Miepee opened this issue · 6 comments

image

This was achieved by just putting columns into the tabs example:

{{< tabs "uniqueid" >}}
{{< tab "macOS" >}}

## macOS

{{< columns >}}
asdf
<--->
qwer
{{< /columns >}}

This is tab **macOS** content.

Dolor sit, sumo unique argument um no. Gracie nominal id xiv. Romanesque acclimates
investiture. Ornateness bland it ex enc, est yeti am bongo detract re. Pro ad
prompts feud gait, quid exercise emeritus bis e. In pro quints consequent, denim
fastidious copious quo ad. Stet probates in duo.
{{< /tab >}}

{{< tab "Linux" >}}

## Linux

This is tab **Linux** content.

Dolor sit, sumo unique argument um no. Gracie nominal id xiv. Romanesque acclimates
investiture. Ornateness bland it ex enc, est yeti am bongo detract re. Pro ad
prompts feud gait, quid exercise emeritus bis e. In pro quints consequent, denim
fastidious copious quo ad. Stet probates in duo.
{{< /tab >}}

{{< tab "Windows" >}}

## Windows

This is tab **Windows** content.

Dolor sit, sumo unique argument um no. Gracie nominal id xiv. Romanesque acclimates
investiture. Ornateness bland it ex enc, est yeti am bongo detract re. Pro ad
prompts feud gait, quid exercise emeritus bis e. In pro quints consequent.
{{< /tab >}}
{{< /tabs >}}
xoxys commented

Thanks for your report!

Thank you for fixing it :)

Actually after testing it now, it doesnt seem to be completely fixed
(screenshot coming soon after i figure out a root cause...)

xoxys commented

Hmm, for me, it's working fine, but I can take a closer look again tomorrow.

image

Ok i think i figured it out. seems like commented out html seems to break it:

{{< tabs "prep" >}}
{{< tab "works" >}}

yay
{{<columns>}}
column1
<--->
column2
{{</columns>}}
{{< /tab >}}
{{< tab "not worky" >}}
nay
{{<columns>}}
column1
<!--{{<img name="screenGuideSetup" size="small">}}-->
<--->
column2
<!--{{<img name="viewsSetup" size="small">}}-->
{{</columns>}}

{{< /tab >}}
{{< /tabs >}}

grafik

screenGuideSetup and viewsSetup are defined valid resources that show up if used properly.

EDIT: It seems like images in columns break in general. If they are uncommented, they also show codeblocks:
grafik

xoxys commented

Thanks. Well images in columns works, images in tabs works too, but actually images in columns in tabs breaks 🤣 To be honest, the nesting of hugo shortcodes is terrible... But I think we can fix this case as well.