thegetty/quire

Remove `classes: [page-one] from default starter

Erin-Cecele opened this issue · 2 comments

Before proceeding, check to make sure there isn’t an existing issue for this idea or a similar one.

  • I have searched the existing issues and determined this is a new proposal.

Proposed change

Remove page-one to prevent users from applying it incorrectly in their projects.

Potential Impact

Advanced users will now need to know to apply it so double check that documentation is sufficient. Advanced users will now need to know how to apply it, so double-check that documentation is sufficient.

Supporting Information

No response

@geealbers @Erin-Cecele Unless I've misunderstood this issue should you also consider renaming page-one to something like page-pdf-number-reset? The class doesn't have a large footprint in the markup+css (though I'd want to triple-check) and wraps a very specific styling function, or so it seems.

Thank you for this feedback @cbutcosk. I will take it to the rest of the team.