theheraldproject/herald-for-ios

Analysis API is private not public

adamfowleruk opened this issue · 3 comments

Attempting to use Analysis API components fails because they have erroneously been made private classes rather than public, reusable, classes.

Issue is that whilst the API classes and their methods subclassing Aggregate are public, Aggregate itself is default (Herald package only) visibility. This means developers cannot create their own Aggregates!

See

@adamfowleruk seems like the class and it's methods need to have "open" access level:

https://docs.swift.org/swift-book/LanguageGuide/AccessControl.html
https://medium.com/hash-coding/swift-access-control-ios-dab45a0b79ab

I was still getting the error I mentioned at the beginning after updating to 2.1.0-beta2 but then switching to open access level seemed to have solved it.

I created a PR for this: #179

Thanks I'll test and merge.