theislab/batchglm

issue with sizefactors when using sparse matrices

SabrinaRichter opened this issue · 2 comments

When running the unittest for graphs and checking wether size_factors is None here:

if input_data.size_factors is not None:

it seems to be None, when setting sparse=False, but not to be None, when sparse=True.

Also here:

if size_factors is not None:

sizefactors are None when X is not sparse and not None when X is sparse.
I just can't figure out where sizefactors are set to something not None, when X is sparse.

@SabrinaRichter is this still relevant? The issue is nearly 3 years old. We have decided to retire support for tf1 entirely. I haven't seen this behaviour in tf2 backend nor in numpy backend. Both will be using an entirely restructured input data processing pipeline and this seems to be a problem specific to the input data processing in tf1 backend. I close this for now.