thejamesthomas/javabank

Add TCP stub support

Opened this issue · 2 comments

Add TCP stub support

Any chance this will ever be done?

I know you can just switch the type up by doing a put("protocol", "tcp") on the Imposter object itself.

Hard to say, honestly. At the moment I've got a lot of other things that are a higher priority for me. I might have some time in December or January, but that'd be the earliest I could get to it. It could probably be done pretty quickly, but I think this change would warrant doing some updates to the domain model, it's pretty anemic right now. Things like properly modeling the unique attributes of each protocol, and such.

However, I would totally accept a pull request that implemented a proper TCP imposter, and would happily handle merging it and getting it released to the central repository. And if you'd like to take a crack at it, I can make some time to advise you.