thekaganugur/formik-chakra-ui

Remove default marginY value?

bjoluc opened this issue · 3 comments

bjoluc commented

Hi @kgnugur and thanks for making my life a bit easier with this lib 😄
I decided to open a new issue on this to continue the discussion from #9. I would like the my={4} setting to be removed as well, since it eases the transition from plain Chakra UI components and users can still pass it if they want to. One might argue that a user may also pass my={0} to every component (which is what I do right now), but generally, I think, it is better practice to use a Grid with rowGap={8} for this kind of styling. My opinion though, and your opinionated lib 😉

thekaganugur commented

Hey thank you,

I will release a new version, with margins removed

  • 👍1
bjoluc commented

Neat, thanks in advance! 🚀

thekaganugur commented

You can take a look at '1.4.4' 🎉

  • 🎉1