thelarz/MvcBreadCrumbs

Localized?

Closed this issue · 12 comments

How To use Localized This BreadCrumb?

I'm not sure what you need. If you want to issue a pull-request with your changes, I'll consider merging it in. Thanks!

Is there way to use Localized Resource for label?

We could potentially implement something like this http://stackoverflow.com/a/359360/3435313

Yes Of course.
On Apr 13, 2016 17:00, "vavanv" notifications@github.com wrote:

Is there way to use Localized Resource for label?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9 (comment)

The example used DisplayNameAttribute but we are using ActionFilterAttribute
I think, we need another Attribute - like BreanCrumbLabelAttribute and in use it in BreadCrumbAttribute
like http://stackoverflow.com/questions/19412483/mvc3-can-you-give-controller-a-display-name

Yes, of course. I was just showing that as an example.

I am going to try in local dev env and if it works will ask to merge the solution

it works fine by adding BreanCrumbLabelAttribute : DisplayNameAttribute and use it in BreadCrumbAttribute.
Needs more dev to finalize it

I am implemented it using existing DisplayAttribute, not sure how to proceed with pushing (never done it before)... could smbd explain? Thanks

As long as you "forked" to your own repo correctly, you should be able to commit/push your changes to remote and then go to github and create a pull request.

https://help.github.com/articles/using-pull-requests/

I forked, made changes, and created a pull request

I've deployed the localization change pull-request. Closing the issue. Thanks folks!