themix-project/oomox-gtk-theme

Minor XFCE Arrow Visual Bug

actionless opened this issue · 8 comments

From @KUPOinyourWINDOW on November 19, 2017 16:12

screenshot_2017-11-19_16-10-38

When you open up a music player, then go into the XFCE sound menu (which is GTK3) the arrows that appear to scroll have an ugly white highlight colour. Thanks for your time and work!

Copied from original issue: themix-project/themix-gui#108

does it have it only on hover or always?

Only on hover

i was trying Majaro XFCE vm recently (to make the recent xfce bugfixes) however i didn't found there that audio widget, what's the name of it's executable so i can install and run it? or mb the issue reproducing in some other places?

I'm not too sure as I don't have much experience with Manjaro (only installed it once, and the install didn't last long).

It's the one that comes standard in Xubuntu, but that's all I know :(

but can you see the same problem with any other app may be?

It's in all the GTK3 indicators with enough items to be scrollable

In gtk+ <=3.18, it's defined in .menuitem.button:hover:
https://github.com/actionless/oomox-gtk-theme/blob/master/src/gtk-3.0/scss/widgets/_menu.scss#L129

In gtk+ >=3.20, it's defined in menu > arrow:hover:
https://github.com/actionless/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/widgets/_menu.scss#L173

I think this can be fixed by replacing
mix($fg_color, $base_color, .1) to mix($menu_bg_color, $menu_fg_color, .1).

Or if you prefer normal menuitem colors, you can specify
$selected_bg_color (and $selected_fg_color for color) like <=3.18 menu buttons. :)

@nana-4 thanks a lot!

hope now it should be fine