themix-project/oomox-gtk-theme

GTK+2 real EOL

actionless opened this issue · 16 comments

actionless commented

Let's define some kind of list of important GTK+2 apps, so after all of them will be finally ported to gtk3 or other toolkit we could stop updating gtk2 theme.

I would start from:

apps using GTK+2 style:

  • Qt5 (gtk2 support dropped in 5.7)

  • Qt4 apps (qt4 dropped from arch linux repos):

    • Clementine (1.3.1 is on Qt5)
    • Mumble (1.3.0 is on Qt5)

  • ARandr (0.1.10 is on gtk3)

  • Sublime Text (migrated to GTK3 as of version 3.2)

  • Geany (mainly ported, some plugins still in progress)

  • GParted (ported to gtkmm3 in 1.0)

  • Inkscape (1.0 is on gtk3)

  • GIMP (in progress, 2.99.2/3.0 should be with gtk3)

  • Pidgin (done, gtk3 support gonna be released in 3.0)

  • Viewnior (in progress)

  • Hexchat (discussion)

  • Nitrogen (discussion)

Also if the project wasn't receiving update in a latest half-year it can be removed from the list.

smurphos commented

There are also QT4 apps that are set to pull from the GTK2 theme. At least that's what happens on my GTK3.18 set-up.

actionless commented

thanks, i've updated the post

smurphos commented

VLC & KeePassX (no longer maintained) can be added to the list of QT4 apps. Looks like some QT5 apps aswell - for example KeepPassXC on QT5.5 looks like it's picking up the GTK2 theme.

alexarnaud commented

There is also Mumble that used Qt4.

Is there any technical reason to drop GTK2 support ?

Best regards.

actionless commented

@smurphos VLC already ported to Qt5

on QT5.5 looks like it's picking up the GTK2 theme.

it's completely broken on hidpi displays so i pretend what that mode doesn't exist (and so do use qt5ct Fusion and palette generated by oomox for those couple of Qt apps i have)

also i think i saw what it's in their roadmap to use gtk3 later on, i hope hidpi issues will be addressed together with that

@alexarnaud lot of gtk+3 theme features got declined to be implemented because it's not possible to make them look consistent with gtk+2 theme

actionless commented

i've updated the list

pandasauce commented

SublimeText, KeepPass2, Thunderbird, Electron apps (tested on Telegram), Spotify also belong on this list, unfortunately. I don't think that at this rate GTK2 support can be dropped any time soon without impact.

actionless commented

chrome/electron taking from gtk2 theme only colors and few other random values from style context, not really using gtk2 itself (i did some investigation of chrome and firefox gtk support-related code when was implementing similar kind of partial gtk3 support for AwesomeWM; btw firefox for that regard using values from both (!) gtk2 and gtk3 themes, but with newer versions mostly gtk3), but neither chrome/electron neither firefox/thunderbird are using gtk2 theme directly anymore.

regarding keepass see messages above

where spotify is using any colors from gtk2?

sublime text will add to the list

but again, deprecating gtk2 theme means only what it will stop updating to be in sync with new gtk3 theme features, not fully removing it.

so for such case of partial integration (where apps just randomly taking some values from gtk2 stylecontext), nothing should be affected since gtk2 and gtk3 oomox themes still will have the same colors

carlos22 commented

Qt5 has dropped gtk2 theme support with 5.7 (over 2 years ago). The QGtkStyle was moved to a different repo and is not shipped by default with the most distributions (as far as i know). QGnomePlattform plugin for example added support for Kvantum [1] themes (besides native qstyle themes with the same name as the current gtk theme). I think for Qt it would be better to add a Kvantum [2] based style then maintaining gtk2.

[1] https://github.com/FedoraQt/QGnomePlatform/blob/master/src/gnomehintssettings.cpp#L232
[2] https://github.com/tsujan/Kvantum/tree/master/Kvantum

actionless commented

@carlos22 thanks for the info, i've updated the first post;

re: kvantum feel free to file a new issue

pandasauce commented

SublimeText migrated to GTK3 as of version 3.2

actionless commented

@pandasauce thanks for info!

cwendling commented

Geany supports GTK3 for a long time now, and more and more distributions are building it that way now. It still supports a GTK2 build and some of its plugins only work with GTK2, but it's catching up.

actionless commented

i think gtk 4.0 release would be a fair moment to stop updating gtk2 theme officially (though not removing it yet)

CoelacanthusHex commented

inkscape 1.0 is with gtk3 now

  • 👍1