Migrate over to using `thenewboston-js` repo

Question

Migrate over to using `thenewboston-js` repo

Opened this issue 3 years ago · 13 comments

angle943 commented 3 years ago

Make the AccountManager rely on thenewboston-js repo fully

Answer 1 · 2021-03-04T16:04:41.000Z

please get permission from me to work on it before you start

Answer 2 · 2021-03-04T16:20:02.000Z

@angle943 Can I work on this

Answer 3 · 2021-03-04T16:35:18.000Z

i don't believe the sdk library is ready yet. talk to @zinoadidi about the progress

Answer 4 · 2021-03-10T17:10:00.000Z

This would be useful for this task.
https://docs.google.com/document/d/1FaPq2stWP0lMtHATNIfLA6ryMd0PtUYdcnrvZbUk7FI/edit
Its a documentation of the similar functions and their locations between Account manager and thenewboston-js

Answer 5 · 2021-03-28T15:37:38.000Z

Hey @angle943, is the list of functions in the document above okay for the account manager or is there anything u would like to add to this list.

Answer 6 · 2021-03-30T03:46:22.000Z

@tomijaga to be honest I currently don't have the bandwidth to look over the document in detail. But we can start going as is. Are you working in tandem with @zinoadidi about these issues?

Answer 7 · 2021-03-30T04:35:42.000Z

@angle943 I have already a roadmap item for the switch, I will handle the process from my end with @tomijaga.

Also we are working together to make missing features already, once they are complete, I will kick off milestones for the conversion process

Answer 8 · 2021-03-30T16:45:54.000Z

@angle943 since development for this is starting soon, can you make a dedicated branch for us so @tomijaga can make all PR to. and when specific milestones will be complete, we can just sync the branches and merge a group of completed tasks to development

Answer 9 · 2021-03-31T00:33:38.000Z

@zinoadidi hmm perhaps it might be better to sync up offline later, but question for you, how soon do you think you can incorporate the AccountManager with the SDK? The reason why I ask is that we are soon having a switch to beta, which might end up changing a lot of our BE end points and results

Answer 10 · 2021-03-31T05:21:19.000Z

@angle943 I have also considered this as well and the proposal is we are going to sync up the SDK development with beta updates as they come; I am working to secure one or two contributors who will be dedicated to this activity.

Concerning Account Manager, there is approximately 1 task pending test from the list of missing functionalities we started to work on a couple of days ago.
That means we can already start switching usage by Friday / weekend (@tomijaga is dedicated to this task)

According to our roadmap; we plan to keep the account manager in sync with SDK no matter what :) and we are ensuring this happens by such kinds of tasks thenewboston-blockchain/thenewboston-js#88

Answer 11 · 2021-03-31T05:51:34.000Z

sounds good, here is the migration branch: https://github.com/thenewboston-developers/Account-Manager/tree/javascript-sdk-migration

Answer 12 · 2021-04-12T11:26:42.000Z

@angle943 All changes are done and ready for review

Answer 13 · 2023-11-20T14:39:08.000Z

Is this closed or bounty open ?