thenewboston-blockchain/Website

Convert GoToTop, Loader to styled-components

Closed this issue · 7 comments

jamessspanggg commented

Task Description

Convert GoToTop, Loader component from scss to styled-components.

To Note

Styled-component migration guidelines:

  • Styled-components should be a separate file called Styles.ts
  • When importing styled-components to component file, should use `import * as S from ‘./Styles’.
  • Use semantic naming for styled-components
  • Try to maintain alphabetical order for css properties
  • Avoid creating styled-components for HTML elements that do not require styling
  • Can refer to src/components/Avatar/Styles.ts for examples
  • Please ensure that the existing UI is not affected, then only seek for reviews

Please only work on the issues that you are assigned to, PRs will be ignored if you are not assigned to the task. If the assigned issues have not been worked on for more than 3 days, we will remove the assignment.

mpmadhavig commented

Hi, Can I work on this issue?

thesanjeevsharma commented

@MadhaviG97 Yeah, go ahead!

  • 👍1
alpha-titan commented

Can I work on this?

thesanjeevsharma commented

@MadhaviG97 Were you able to make some progress with this? If you won't be doing it, let me know, I'll re-assign to someone else.

  • 👍1
  • 👀1
mpmadhavig commented

@MadhaviG97 Were you able to make some progress with this? If you won't be doing it, let me know, I'll re-assign to someone else.

Yeah I am working on it. Extremely sorry for not replying.

  • 👍1
Creatinas commented

Can i take this one?

thesanjeevsharma commented

@Creatinas this is already fixed, forgot to close this. my bad.