[Task] Investigate `thenewboston-node` Document how the features implemented affects the JS SDK
zinoadidi opened this issue · 8 comments
Task
Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!
Overview
In https://github.com/thenewboston-developers/thenewboston-node/tree/master/thenewboston_node/business_logic/tests
You will find different tests for features that are internal as well as possible exposable features.
Compile a list of tests that could be as part of the final API documentation when this task will be ready thenewboston-blockchain/thenewboston-node#29
Note: this task is ongoing and should be visited as new tests are added or more clarification is gotten from the team working on tnb node
Submit a google doc with the list of tests/features which look like public features as well as possible places where they can fit in our existing system or as part of a brand new set of classes.
Behavior
- a living document that identifies and groups possible features based on existing tests.
Please ask for this task to be assigned to you and earn and its sweet reward 😉
Remember to include your account number in your PR description for us to pay you 💰
** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing
@zinoadidi Please, be aware that the API will be ready after this task is completed: thenewboston-blockchain/thenewboston-node#29
@dmugtasimov, the Plan is to keep the sdk development in sync so that BETA features are available as soon as they are ready on node or a few weeks after
That's why I wrote earlier asking about documentation.
It would be nice if the apis are made as features are completed rather than at the end of the whole thing so we can follow as well and make corrections were necessary.
In a nut shell we are not interested in creating apis we just need to know what features are available what data is needed to send and what output
Maybe It's time to make a branch called beta.
yes @mrbusysky the branch comes sooner;
I just need a concrete task that will go into it + I want all changes that come from Account manager integration to be done before switching focus/attention
I'll work on this
subscribe to this task thenewboston-blockchain/thenewboston-node#29 . the description may be useful