thenewboston-blockchain/thenewboston-js

Wrong CV Config Response

Closed this issue · 0 comments

Describe the bug
The Confirmation Validator Config Response is wrong

To Reproduce
Steps to reproduce the behavior:
https://github.com/thenewboston-developers/thenewboston-js/blob/master/src/models/responses/confirmation-validator/config.ts

Expected behavior

export interface PrimaryValidatorConfigResponse {
  primary_validator: {
    account_number: Hex;
    ip_address: Origin;
    node_identifier: Hex;
    port: Port | null;
    protocol: Protocol;
    version: Version;
    default_transaction_fee: number;
    root_account_file: Url;
    root_account_file_hash: Hex;
    seed_block_identifier: Hex;
    daily_confirmation_rate: number | null;
    trust: Trust;
  };
  account_number: Hex;
  ip_address: Origin;
  node_identifier: Hex;
  port: Port | null;
  protocol: Protocol;
  version: Version;
  default_transaction_fee: number;
  root_account_file: Url;
  root_account_file_hash: Hex;
  seed_block_identifier: Hex;
  daily_confirmation_rate: number;
  node_type: NodeType;
}

** Pull Requests **
All Pull Request should be made against development branch read contributors guide for more information about contributing