thenewboston-blockchain/thenewboston-js

minified file not in releases

Opened this issue · 5 comments

AbhayAysola commented

Describe the bug
The minified tnb.min.js file is not included in the releases.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/thenewboston-developers/thenewboston-js/releases
  2. See that the min file is not included in the assets

Expected behavior
I expected the min file to be included.

** Pull Requests **
All Pull Request should be made against development branch read contributors guide for more information about contributing

zinoadidi commented

do we want to include minified file or release only minified file @AbhayAysola

AbhayAysola commented

do we want to include minified file or release only minified file @AbhayAysola

I think we should include the minified file. A seperate release might be too confusing for new developers

zinoadidi commented

This brings us to a wider topic as at the moment github released are created manually not part of the existing automated actions that publishes the new npm version

For this to be added without having to do manually 1 additional step, we need to automate github release process so it builds / minifies project then create the release along with changelog and etc

AbhayAysola commented

This brings us to a wider topic as at the moment github released are created manually not part of the existing automated actions that publishes the new npm version

For this to be added without having to do manually 1 additional step, we need to automate github release process so it builds / minifies project then create the release along with changelog and etc

Hmm that could be done, I'll close this issue in favour of automating releases in the future.

zinoadidi commented

I think we csn keep it open and link it to the automation task when it will be opened

  • 👍1