thenikso/github-plus-theme

Colour issue on string template variables in Javascript

prajapati-parth opened this issue · 2 comments

When access an object's value using the dot notation, the dots are displayed on when the cursor is place on the dots, else it matches with the background colour.

Without cursor
Screenshot 2020-03-12 at 10 34 18 AM

With cursor
Screenshot 2020-03-12 at 10 34 39 AM

Add this to your settings json file for vscode until the issue is fixed:

 "editor.tokenColorCustomizations": {
    "[GitHub Sharp Dark]": {
      "textMateRules": [
        {
          "scope": [
            "keyword.operator.accessor",
            "meta.group.braces.round.function.arguments",
            "meta.template.expression",
            "markup.fenced_code meta.embedded.block"
          ],
          "settings": {
            "foreground": "#c3c6c9"
          }
        },
      ]
    },

thank you @zackkrida for the workaround. however this particular theme (GitHub Plus) only has a light background variant. so that has indeed been addressed in the other theme repo :)