thenikso/github-plus-theme

Change CSS values color

bezvoshchuk opened this issue · 2 comments

Hey Nicola!
Thank you for the awesome theme!
Everything is nice in it, I switched to it, but I think CSS looks a bit monotonous:

screen shot 2017-11-29 at 00 05 50

In my opinion it would be much better if CSS values color was black.
What do you think about this?

I believe your suggestion is quite meaningful.
But right now it's exactly like Github styling is applied. For some people it might be the case.

Of course we should wait for maintainer's answer.

.main-wait-bar.is-show {
  width: 100%;
  height: 100%;
  color: #000;
}

Probably, it would be better if you will apply the styling through your VS Code preferences by editor.tokenColorCustomizations using textMateRules property.

The value for "textMateRules" may be like this:

 "editor.tokenColorCustomizations": {
  "textMateRules": [
     {
        "scope": [
          "constant.numeric.css",
          "support.constant.property-value.css",
          "support.function.misc.css",
          "constant.other.color.rgb-value.hex.css",
          "punctuation.section.function.begin.bracket.round.css",
          "punctuation.section.function.end.bracket.round.css"
        ],
        "settings": {
          "foreground": "#353535",
        }
      }
    ]
  }

The result will be something like this

Changed syntax styling

Sure, there are some CSS language entities that are not covered by this rule set, but you may want them to be applied. For such a case, I recommend you to see this official guide

thanks a lot! I've added these here 66a076a and will publish soon