theonion/videojs-vast-plugin

Clicktracking gets ignored when using VASTAdTagURI

Closed this issue · 4 comments

Hi there,
I am running into an issue here with a vast-wrapper i tried to load. The clickthru-URL from the second XML gets fired, but the clicktracking from the first XML is ignored.. any Ideas here?

Additional Question:
The second XML also has a node "AdParameters" with content and some VAST-extensions declared at the bottom. Could that be a show stopper?

Would be thankful for any suggestions!

Cheers,
Steve

hwde commented

I assume you use a newer version of vast-client, the property for clickTracking URLs has changed to clickTrackingURLTemplates and it is already an array, if you change around line #196 from

                        var clicktrackers = player.vastTracker.clickTrackingURLTemplate;
                        if (clicktrackers) {
                            player.vastTracker.trackURLs([clicktrackers]);
                        }

to

                        var clicktrackers = player.vastTracker.clickTrackingURLTemplates;
                        if (clicktrackers) {
                            player.vastTracker.trackURLs(clicktrackers);
                        }

it should track ...

Hey man,

thank you for sorting that out. I was already looking at that line and wondering if it was an array or not. Will try that now and get back to you,

thanks again,
steve

hwde commented

Please note also the trailing "s" 😊

Von unterwegs gesendet.

Am 27.07.2016 um 19:15 schrieb sonicsoul notifications@github.com:

Hey man,

thank you for sorting that out. I was already looking at that line and wondering if it was an array or not. Will try that now and get back to you,

thanks again,
steve


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Hey,
I forgot to get back to you yesterday, clicktracking is working fine again, thanks !!

Cheers,
Steve