Move from FAAD2 to fdk-aac to fix #260 broken Parametric Stereo implementation on subchannels?
Closed this issue · 5 comments
Was going over this #260 and discovered that if I checkout this old build https://github.com/theori-io/nrsc5/tree/72c51de9c58f93200d011ade6e0954b27dcc83c4 and load a transcoded ADTS file into audacity it seems play correctly.
If I load that file into VLC it sounds awful and similar to the issues reported here.
Seems like #88 may also be a similar issue to this.
At that time it was proposed to move from FAAD2 to fdk-aac so I'm not sure if that will fix this issue.
I wonder if FAAD2 is not handling Parametric Stereo correctly.
Just some obversions I noticed today.
@argilo not sure if any of this is useful
EDIT: If you want convert stuff now a bit more easily you can checkout a old branch and use a separate converter #88 (comment)
Some more testing on this would be good to see if it's just me or if this actually fixes the issue.
@argilo I figure moving to fdk-aac would be a massive amount of work. Provided the current patch can be adapted for it.
I wonder if it's worth it to bring transcoding back but mention requires a media player that doesn't use FAAD2 as a easy workaround for now?
I tried myself by checking out that old build and outputted adts. I played it through FFmpeg and it sounds good.
Was this with with a low bitrate channel that is is in mono with the current build?
Yes, it was at low bitrate at 30kbps on a subchannel. I forgot to mention that.