thepassle/generic-components

`getFocusableElements` doesn't get all focusable elements

Closed this issue · 1 comments

E.g.: the util may get a button, but if that button is disabled, it's still not focusable, among many other quirks related focusability/tabbability/tabindex.

This util is used to set focus to the first focusable item in a dialog container when a user tabs from the browser url bar back into the browser while a dialog is open. Currently there's also no fallback if there is no focusable element in the dialog (which is not recommend anyway; there should be a close button).

Maybe its acceptable to simply set focus to the dialog container itself. Would love to hear some feedback from a11y gurus on this.

fixed in ec3f803

Setting focus back to dialog container for now.