thephpleague/flysystem

phpseclib3 for the sftp adapter

Closed this issue ยท 9 comments

stof commented

Question

Is there any plan to update league/flysystem-sftp to use phpseclib3 instead of phpseclib 2, so that it supports newer crypto algorithms ? See also thephpleague/flysystem-sftp#111 and thephpleague/flysystem-sftp#110 but I figured out that the 2.x branch of league/flysystem-sftp is actually a subtree split from here so I'm bringing it here.

Also, the namespace for the class in v2 includes PhpseclibV2 so I don't see what the plan could be when migrating to v3

@stof We could use https://github.com/phpseclib/phpseclib2_compat to maintain compatibility with both.

There is a PR starting to add a PhpseclibV3 for Flysystem 2

#1257

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stof commented

this issue is still relevant, as the PR is still in progress

any progress? i have the same problem with server host key

I've merged the PR for this. Interested people can try the v3 variant here: https://packagist.org/packages/league/flysystem-sftp-v3

Any feedback on this before I tag an stable version?

I just upgraded a rather large application from flysystem-sftp to flysystem-sftp-v3 to gain support for DSA keys. In our dev and staging environment everything seems to work as expected. Are there any plans to release a stable version soon?

I tried v3 today, haven't noticed any issue, seem to be working as expected.