thephpleague/oauth2-client

getResourceOwner parameter type

nrob81 opened this issue · 1 comments

nrob81 commented

Hello,

Doesn't would be better to set the type of the $token parameter here to AccessTokenInterface instead of AccessToken?

oauth2-client/src/Provider/AbstractProvider.php

Line 765 in 8c7498c

public function getResourceOwner(AccessToken $token)

what do you think?
Thanks

esolitos commented

While you are absolutely correct: it would be better to expect Interfaces and not specific implementations, it is to consider that this small change would require a new major release because it would break bacward compatibility, as it happened in the past (ref #753 and #752 for example).

And I highly doubt a new major release will be created only for this alone.

Edit: as a matter of fact this is already being tracked in #897 :)

  • 👍2