therungg/therun-frontend

Changes to eslint due to incompatibilities (CRLF on windows)

zoglo opened this issue · 1 comments

zoglo commented

The current eslint config doesn't work for people working on windows as it'll detect every crlf and throw following error in my IDE:
'ESLint: Delete `␍`(prettier/prettier)'


Changing the config from

{
  "extends": [
    "next",
    "prettier",
    "next/core-web-vitals",
    "plugin:github/recommended"
  ],
  "plugins": [
    "react",
    "github"
  ],
  "rules": {
    "@next/next/no-page-custom-font": "off",
    "react-hooks/exhaustive-deps": "off",
    "@next/next/google-font-display": "off",
    "filenames/match-regex": "off",
    "no-irregular-whitespace": "off",
    "import/no-named-as-default": "off",
    "github/array-foreach": "off",
    "eqeqeq": "off",
    "i18n-text/no-en": "off"
  }
}

to

{
  "extends": [
    "next",
    "prettier",
    "next/core-web-vitals",
    "plugin:github/recommended"
  ],
  "plugins": [
    "react",
    "github",
    "prettier"
  ],
  "rules": {
    "@next/next/no-page-custom-font": "off",
    "react-hooks/exhaustive-deps": "off",
    "@next/next/google-font-display": "off",
    "filenames/match-regex": "off",
    "no-irregular-whitespace": "off",
    "import/no-named-as-default": "off",
    "github/array-foreach": "off",
    "eqeqeq": "off",
    "i18n-text/no-en": "off",
    "prettier/prettier": [
      "error",
      {
        "endOfLine": "auto"
      }
    ]
  }
}

will skip that end of line error.


Wdyt @therungg ?

Sure, added to main! Good suggestion.