[Bug]: GA 'Deploy Landing' job fails resulting in landing page not linking to the latest binaries
Closed this issue · 4 comments
What happened?
Probably you've noticed the failed job already, but just in case - the deployed landing page links to v.2.0.0 binaries (when 2.0.1 are out).
Could it be a Github environment's permission issue?
Steps to reproduce
https://thewh1teagle.github.io/vibe/
https://github.com/thewh1teagle/vibe/actions/runs/9354853827
What OS are you seeing the problem on?
No response
Relevant log output
No response
Thank you for bringing this to my attention! I'm still undecided on the best course of action. Currently, the links update when the landing job runs. However, if it runs too frequently in a short period, the releases file may not be fetched reliably. Nonetheless, it should still be fetched as it's bundled into the static files.
However, if it runs too frequently in a short period, the releases file may not be fetched reliably
Sounds strange.
Could it be an issue with the concurrency parameter? Would cancel-in-progress: true give priority to the latest (and presumably most up to date) job?
From looking again in the action run the error happens when the action run from new tag trigger. Normally it doesn't happen
Fixed in d66dd05
I just used Github token from secrets (added manually) instead of default of actions for better rate limits