A github selfie appeared and wiped out my inline comment!
Closed this issue · 4 comments
I was going about my business and commenting on a PR inline in the diff when I saw the selfie button. I hadnt used the extension in a while and had just been talking with my coworker about how we need to bring selfies back into the process, so I decided to do one. When I completed my priceless selfie gif, it wiped out the content of my comment! While often the selfie can express everything and more that I need to say, in this case it would have been nice to have words as well. Just wanted to let you know. k thx bai.
+1. It should do a find and replace on the strings it needs to find and replace, rather than wiping your entire comment.
That's certainly what it's trying to do: https://github.com/thieman/github-selfies/blob/master/chrome/selfie-base.js#L176
Will take a look, thanks.
Strange. I can't reproduce when trying to show the problem now. Will screencast the next few times I try to do this to see if I can isolate the issue.
Closing without reproduction, please re-open if you can get it to happen again.