thinknimble/tn-spa-bootstrapper

React client missing lockfile

Closed this issue · 2 comments

We should include a lockfile to avoid version issues

We've been using mostly yarn lately so probably a yarn lock would be a good call

Okay I know why we didn't include one. Given that gql and rest variants of the react app require different libraries we opted not to include the lock file.

An alternative for this might be to keep both lock files and keep the corresponding one after cookie cutter ran with a post script

Although a lockfile would be a better practice. Since we're going to handle different packages depending on how we bootstrap we might want to just fixate the versions in the package.json instead. Any upgrade could be done consciously if required