thlorenz/es6ify

Bump traceur version?

Closed this issue · 11 comments

It's advancing quite rapidly these days.

Sure, we should just run the tests once and hope for the best :)

Looked into this, looks like API changed a lot.
None of these are there anymore.

This is gonna take a bit more than just npm update to get right.
I'm gonna have to look through the traceur commits to see what API I need to use now.

Don't have that kinda time on my hands this week, so PR welcome in the meantime, otherwise it'll have to wait a bit.

Rargh want to advertise es6ify at BrooklynJS tonight but not sure if good idea because it uses outdated traceur :-/. grunt-traceur is probably better...

I've upgraded to latest traceur in my fork over here: https://github.com/bjoerge/es6ify

Ran into a few issues and had to do a couple of workarounds to make the test suite pass, but I'll explain them better in a pull request here when I get the time (probably by the end of the week).

@bjoerge ok, looking forward to the PR. Hopefully test changes are acceptable and your changes are backwards compat.

Would love to pull something in that gets us updated to the latest traceur finally.

@domenic the hard part for es6ify is to integrate traceur API into browserify bundle/transform chain.

Is grunt-traceur a transform that works with browserify or is it just using traceur on separate file?
Does it support sourcemaps?

So fwiw you should probably consider these questions before dropping es6ify from your talk ;)

@domenic actually looked into grunt-traceur (hoping to learn how to use new traceur api).
Learnt that it actually uses an even older traceur version than es6ify ;)

But nice try in egging me on :P

I'm very hopeful we'll get something working either way as I indicated above. I also want to see extra ES6 features supported in es6ify.

+1

@bjoerge I looked into the code in your fork and it looks quite good to me.
As far as I saw there was only a minor change to one test.

Would you mind doing a PR from that fork so we can discuss how to best pull it in and resolve some questions I and others may have (i.e. modules: 'commonjs' setting)?

Otherwise I can just cherry-pick your changes, but a PR would be preferred.
Thanks.

Cool, thanks. Will submit PR later today.

Bumped in 1.0.0.