thom4parisot/tld.js

returns null for http://vikram_tiwari.com

VikramTiwari opened this issue · 4 comments

similar to #117

Hi @VikramTiwari,

Thank you for your feedback!

In this case, this is because currently the _ is not considered valid when found inside a domain. Related work: #122

Hopefully we will soon have a better behavior and a way to customize it.

@remusao You are not merging #122 into master for now?

@luckyb56, I'm all for it, but I would like to get some feedback from @oncletom on this one. I also opened another PR #128 to propose a possible new set of defaults (which would also solve the issue of hostname validation, as well as a few other things). How do you think we shall proceed on this?

PR #128 Looks great.