Optimization: remove unnecessary `liftEffect`s throughout codebase
JordanMartinez opened this issue · 1 comments
JordanMartinez commented
I'm pretty sure the liftEffect
here is redundant.
pure $ unsafePerformEffect $ liftEffect $ Ref.modify_ fn stateRef
unsafePerformEffect
takes an Effect
as its argument and Ref.modify_
already returns an Effect
, so I'm not sure why liftEffect
is there. I imagine it was from when Thomas was originally working on this code and exploring different design approaches.
thomashoneyman commented
Yes, this isn't necessary. I'm happy to accept a PR which removes these uses of liftEffect
.