Font Issue
syedsimanta03 opened this issue · 1 comments
Can you please fix the typography.scss? Please use rem instead of px for font size and update the github.
You already know why we should use rem. Use modern tips and tricks. Thanks
Hey @syedsimanta03, that's a good point, thanks for the pointing to this issue! The debate of whether to use rem, em, or px units in CSS is well argued on the web. This is a good guide to the differences: https://webdesign.tutsplus.com/tutorials/comprehensive-guide-when-to-use-em-vs-rem--cms-23984. The main advantage of using px is it's easier for designers and beginners to understand. Not going to change it for purposes of keeping this repository as a reference for the course, but will update the README to reflect the issue. Thanks!