thoth-station/integration-tests

Adviser tests for `rhods` are failing because of error in OpenAPI specification

mayaCostantini opened this issue · 4 comments

mayaCostantini commented

Describe the bug

The following error occurred for adviser tests on the Run thamos advise on an application stack -- @1.3 Advise scenario:

Assertion Failed: Error in HTTP status code 500 for 'https://stage.thoth-station.ninja/api/v1/advise/python/adviser-220301103058-46086ec41eb2edba': {
  "detail": "[{'apiVersion': 'apps.openshift.io/v1', 'kind': 'DeploymentConfig', 'patch': {'op': 'add', 'path': '/spec/template/spec/containers/0/env/0', 'value': {'name': 'TF_ENABLE_ONEDNN_OPTS', 'value': '1'}}}] is not of type 'object'\n\nFailed validating 'type' in schema['properties']['result']['properties']['report']['properties']['products']['items']['properties']['advised_manifest_changes']['items']:\n    {'description': 'A change that was advised', 'type': 'object'}\n\nOn instance['result']['report']['products'][0]['advised_manifest_changes'][0]:\n    [{'apiVersion': 'apps.openshift.io/v1',\n      'kind': 'DeploymentConfig',\n      'patch': {'op': 'add',\n                'path': '/spec/template/spec/containers/0/env/0',\n                'value': {'name': 'TF_ENABLE_ONEDNN_OPTS', 'value': '1'}}}]",
  "status": 500,
  "title": "Response body does not conform to specification",
  "type": "about:blank"
}

Captured logging:
INFO:thamos.lib:Using 'STABLE' recommendation type - see https://thoth-station.ninja/recommendation-types/
INFO:thamos.lib:Successfully submitted advise analysis 'adviser-220301103058-46086ec41eb2edba' to 'https://stage.thoth-station.ninja/api/v1'

To Reproduce
See last integration tests report (Integration tests update for ocp4-stage (2022-03-01 version 0.9.2) at 1:03PM CEST)

mayaCostantini commented

/priority critical-urgent
/lifecycle active
/sig stack-guidance
/assign

mayaCostantini commented

/kind bug

sesheta commented

@mayaCostantini: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.