Need a test for `thamos images`
Closed this issue · 9 comments
thamos images
stopped working correctly after a change in user-api (thoth-station/thamos#1184) and this is not captured by current integration tests.
The current integration tests include containe images API coverage but not from thamos
.
Could'nt we have an automatic PR generating the thamos openapi client when the relevant user-api is updated, and let the usual ci (mypy in particular for catching bad usages) point us to fixes ?
Could'nt we have an automatic PR generating the thamos openapi client when the relevant user-api is updated
That would be nice to have, but we don't have anything similar available yet, right?
and let the usual ci (mypy in particular for catching bad usages) point us to fixes ?
Would mypy catch this particular issue though? I think the problem in the code involved in thoth-station/thamos#1184 is more semantic/logic than what mypy would catch, no?
/assign
do we turn this into a RFE (wrt openapi regeneration...) and close this because auf #351 ?
It might be in a separate issue. I think a integration test for thamos images
is easier than automatic openapi regeneration, and it can probably catch other things.
/sig stack-guidance
/kind feature
/priority important-longterm
Closing as parent issue is resolved and these test will no longer be relevant. As long as /container-images
is tested, then this thamos command will be covered as well because the parent issue removed any additional logic that was applied after the api call.
/close
@Gkrumbach07: Closing this issue.
In response to this:
Closing as parent issue is resolved and these test will no longer be relevant. As long as
/container-images
is tested, then this thamos command will be covered as well because the parent issue removed any additional logic that was applied after the api call./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.