Support for "legacy" source types via Poetry

Question

Support for "legacy" source types via Poetry

avfarooq opened this issue 2 years ago · 9 comments

Poetry designates the source type for every package as 'legacy' in the poetry.lock file if using a 3rd party or proxy repository as I am.

Now micropipenv only supports the source type to be 'git' or 'directory'

I kindly ask to support the 'legacy' value for source type as well, so that micropipenv can be used within an s2i container to build an image via poetry.lock and pyproject.toml files.

Thanks in advance for any help.

Answer 1 · 2022-09-09T10:05:51.000Z

Hi. Could you please provide us an example of pyproject.toml and poetry.lock we can use to reproduce the issue?

Answer 2 · 2022-09-14T07:18:58.000Z

/kind feature
/triage needs-information

Answer 3 · 2022-09-14T15:19:25.000Z

Hi. Could you please provide us an example of pyproject.toml and poetry.lock we can use to reproduce the issue?

My bad on the delay. I'll try to respond today with an example.

Answer 4 · 2022-09-16T17:20:52.000Z

I have attached an example demo repo which has the Poetry example files that replicate this issue. For some context, repositories that use the Simple Repository API are designated by Poetry as typelegacy .. and this prevents the usage of Micropipenv. I'd like to be able to use micropipenv within an s2i builder image as it's one way to use Poetry without having to make a custom dockerfile. Please let me know if you have any questions.

flask-demo.tar.gz

Answer 5 · 2022-09-20T07:30:03.000Z

Thanks for the demo. I'm already working on it and it helped me a lot to understand how poetry and pipenv handle package sources.

Answer 6 · 2022-09-20T11:29:43.000Z

Could you please help me verify that the fix I've prepared and the tests together with it make sense? See the linked PR. Thank you.

Answer 7 · 2022-09-26T08:25:23.000Z

@avfarooq do you plan to take a look at the changes anytime soon? If you don't, please say so and I'll merge it and release a new version today or tomorrow.

Answer 8 · 2022-10-21T02:03:39.000Z

@avfarooq do you plan to take a look at the changes anytime soon? If you don't, please say so and I'll merge it and release a new version today or tomorrow.

Sorry about the super late reply but yes I think the changes are great. Thank you so much! I really appreciate it.

Answer 9 · 2022-10-24T07:53:17.000Z

Sorry about the super late reply but yes I think the changes are great. Thank you so much! I really appreciate it.

A late reply is much better than a no reply. Thanks for that!