thoughtbot/fake_stripe

Rails 5 compatibility

mrgilman opened this issue · 7 comments

I tried to set up fake_stripe in a fresh Rails 5 app, but ran into some dependency problems with Sinatra and Rack. Rails 5 requires Rack 2.0 or higher, and the most recent version of Sinatra requires Rack ~> 1.5. Bundler resolves the Sinatra version to 1.0 because it has a more optimistic requirement for Rack (>= 1.0). This older version of Sinatra does not work because of this error.

In short, I don't think we can make fake_stripe compatible with Rails 5 until Sinatra is compatible with Rack 2.0+.

I'm hopeful that the next version of Sinatra will have support for Rack 2.0: sinatra/sinatra@e7ef8e2

I found the issue where Sinatra is tracking its compatibility with Rails 5: sinatra/sinatra#1135

Thanks, bro! I'm going to work on a Rails 5 compatible fake-stripe pre-release this week.

Works with Rails 5 if the Sinatra beta is specified in the Gemfile; I added a note to README.md.

Since Sinatra 2.0 was recently released, this gem now works without any additional configuration for Rails 5. I think that means this issue can be closed.

I've created a pull request to update the README here: #79

odlp commented

Closing this issue now that Sinatra 2.0 is out in the wild. Thanks for you help everyone!