thoughtbot/griddler

Configuring Reply Delimiter Broken

Closed this issue · 4 comments

When configuring the Reply Delimiter using the config.reply_delimiter = "-- Reply Above --" example in the documentation, we get: undefined methodreply_delimiter=' for #Griddler::Configuration:0x0000000de7d288 (NoMethodError)`

It looks like this functionality was broken here: 57bc70e#commitcomment-16423907

I commented directly in the PR. Thanks. It is likely this was removed accidentally.

I'm going to give the creator of that PR a bit of time to comment on any reasoning behind the removal before putting it back.

As I asked elsewhere, is this currently a blocker for you? This commit is in master and not a gem release, so if it is not fixed ASAP is this ok?

@wingrunr21 no worries, we're happy to wait for the new pull request from @joeadcock

Just merged it

Thank you!