threefoldtech/mycelium

mobile: quic crashes on start-stop-start cycle

Opened this issue · 5 comments

On Android (and probably on iOS as well), latest mycelium crashed on start-stop-start cycle.

steps to reproduce:

  • start android mycelium
  • stop
  • start again

image

Crash message doesn't really point out to quic.
But it is fixed when we force is_private_net var to true

let is_private_net = private_network_config.is_some();

Do we need QUIC on mobile device?
If no, maybe we can disable it as well.

In case we disable it, i think we still need to fix it because this crashes mean there is some process that is not gfacefully shut down

On Android (and probably on iOS as well)

i found that it doesn't crash on iOS

This is rather strange that it only crashes on quic sockets on android. Regardless given that it happens on a second start, I feel that it's caused by not properly cleaning up when the process is done. Mycelium basically spawns a bunch of background tasks which run forever. Up until now, this was fine, since on desktop, if the node exits, we just exit the whole process.

Up until now, this was fine, since on desktop, if the node exits, we just exit the whole process.

FYI, it was fine when i'm working on this PR.
#239

So, it broke after/around that time

@iwanbk I assume this is working properly now?

@iwanbk I assume this is working properly now?

i haven't tested it yet because i disable QUIC now.
will test it next week.