Public IP filtering is broken
Closed this issue · 1 comments
Description
Public IP filtering is broken on devnet weblets. when the user enables the public ip option in any weblet or selects a weblet that requires a public ip then filters the nodes either with the capacity filter or the manual filter, all nodes are returned even the ones that have no public ips and the deployment is allowed but during the deployment it fails as seen below.
Capacity Filter
Untitled_.Mar.20.2023.2_18.PM.webm
Manual Filter
Untitled_.Mar.20.2023.2_19.PM.webm
Steps to reproduce
- Navigate to play.dev.grid.tf
- Enable the public ip option in any weblet or select a weblet that requires a public ip (caprover, casperlabs, node pilot)
- Filter the nodes using the capacity or the manual filter.
- Deploy on any of the provided nodes.
Tested it again on testnet weblets v1.7.0-rc1 and the issue is not present there. both the capacity filter and the manual filters are working fine with filtering nodes that have free public ips.
Screencast.from.26-03-23.12.33.46.webm
However there is a concern that the issue originally mentioned happened since all of the public ips on devnet were used and there were none available, this case is currently hard to test on testnet since there are 40+ free public ips, i'll close this issue for now and try to find a way to replicate the mentioned scenario on testnet and if it was indeed the reason then i'll reopen this issue again with the correct steps on how to reproduce.