threepointone/glamor

Performance issue: process.env.NODE_ENV='test' in release package `lib/index.js`

lazurey opened this issue · 2 comments

Version: 3.0.0-2
Description: ./lib/index.js, line 78, 79 is as the following:

exports.isDev = "test" !== 'production';
exports.isTest = "test" === 'test';

So no matter what NODE_ENV I set, glamor is always running under dev mode which causes a very serious performance issue.

Please help look into this issue and seems it's not fixed in 3.0.0-3.

V3 was deprecated, please use latest version in 2.x

Thanks for the quick reply.
I downgraded to v2.20.40 and ran into the server render issue (link).
If anyone else got a flash screen when server rendering and empty css and ids, you could have a look at your server wepback.config.js and add glamor/server to externals as the previous post mentions.
Besides this, everything else works well, happy to close this issue.