thriveweb/yellowcake

Re-work the click events

Closed this issue · 4 comments

A Hacktoberfest pull request help wanted.
It would be great if someone could help with add all the eslinter requirements the non-native to click events like DIV's.
See all files marked with linter warnings for clickable elements remove this and you will see the warnings.
Thanks @abhijit-hota I've updated this request.

Following this example:
onKeyDown={this.handleKeyDown} tabIndex={0} aria-label="Toggle Popup" role="button"

If you are interested in helping I've started with the Popup.js on this branch.
https://github.com/thriveweb/yellowcake/tree/Popuplinter

What about the styling of the divs when replaced by say, buttons?

@abhijit-hota I've updated this request to help contributors make better changes :)

These have been resolved now. Es linter is back and up and running on all components.