Checkbox HTML includes value attribute even if prop is undefined

Question

Checkbox HTML includes value attribute even if prop is undefined

danoc opened this issue 5 years ago · 3 comments

React adds a value attribute (value="") to input[type="checkbox"] even if the value prop is undefined. This prevents the default browser behavior of value="on" when the value attribute is omitted and causes unexpected bugs if a server endpoint checks for a the checkbox value rather than existence of the checkbox in the form data.

This upstream issue describes this in more detail: facebook/react#17590

Thumbtack employees can also look at IE-545 in JIRA for more context.

Answer 1 · 2019-12-13T00:03:07.000Z

Hi! Seems simple, can I work on this?

Answer 2 · 2019-12-13T00:12:36.000Z

Hi @Amagon96, thanks for reaching out but we already have a PR for it (#590).

Answer 3 · 2019-12-13T01:48:42.000Z

@danoc I see, thanks.

So, the way you fix this is just for thumbprint right? The react issue is still open