Rethink Button and Link components
Opened this issue · 3 comments
danoc commented
This refers to these four components:
Button
andThemedLink
Link
andTextButton
Problems with the current components
There are a handful of open issues related to these components:
TextButton
andLink
inherit theme have different hover states- Add support for basic text styling to
TextButton
andLink
- Link uses inline-block
- Think of how the components that link to pages will work in a SPA world
- Make it easier to use padding with the Link component
And these are issues that aren't already captured:
Link
andTextButton
don't allow for 100% width.<Link theme="inherit" />
and<TextButton theme="inherit" />
is clunky API and doesn't work for complex layouts.
lavelle commented
Would also be good to add the event
argument to the onBlur
and onFocus
methods of these components, as we do for others like TextArea
and Dropdown
lavelle commented
Original Slack Thread (TT employees only) https://thumbtack.slack.com/archives/C0GKYQVTR/p1603911530021700