thunder-app/thunder

NullPointerException with gallery_saver package

Closed this issue · 1 comments

Description
There is currently an issue with gallery_saver which causes crashes on Android (according to crash logs). Looking at their repo indicates that the package is no longer actively maintained: https://github.com/CarnegieTechnologies/gallery_saver/issues

For this reason, we should either

  • try to find an alternative package which can handle the same functions as gallery_saver to resolve these crash issues.
  • implement a solution to prevent the crashes from occurring. This is the relevant issue I found on the repo: CarnegieTechnologies/gallery_saver#152
Exception java.lang.NullPointerException:
  at carnegietechnologies.gallery_saver.GallerySaver.finishWithSuccess (GallerySaver.java)
  at carnegietechnologies.gallery_saver.GallerySaver.access$finishWithSuccess (GallerySaver.java)
  at carnegietechnologies.gallery_saver.GallerySaver$saveMediaFile$1.invokeSuspend (GallerySaver.java)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (BaseContinuationImpl.java)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.java)
  at android.os.Handler.handleCallback (Handler.java:942)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8762)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:604)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1067)

How to Reproduce
Steps to reproduce the behavior: N/A

Expected Behavior
Users should not be crashing when attempting to save an image.

Screenshots
N/A

Device & App Version:

  • Device: Android devices
  • OS: Android (unsure if this also affects iOS)
  • Version: 0.2.1, 0.2.2, 0.2.3

Additional Context
Add any other context about the problem here.

gallery_saver also has a very old http dependency, which is causing other dependency issues with this repo.
It prevents thunder from updating the extended_image dependency, which is needed to fix a build issue.