tidyverse/ggplot2

Release ggplot2 4.0.0

Closed this issue · 4 comments

thomasp85 commented

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Check if any deprecation processes should be advanced, as described in Gradual deprecation
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::build_readme()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::cloud_check()
  • Update cran-comments.md
  • git push
  • Draft blog post
  • Slack link to draft blog in #open-source-comms
  • Have you built the book?

Submit to CRAN:

  • usethis::use_version('major')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • Finish & publish blog post
  • Add link to blog post in pkgdown news menu
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
  • Share on social media
john-harrold commented

I got an email from Thomas Pedersen. It said the following:

I'm writting to you because we are in the process of submitting ggplot2 v4.0.0 to CRAN. With a package like ggplot2 it is almost impossible to make any changes without breaking a test or a functionality in one of the thousands of reverse dependencies and unfortunately your package (nlmixr2rpt) are reported by CRAN as failing.

I'm happy to help out. I downloaded a tarball off of CRAN of nlmixr2rpt so I have the version that is there, then I installed the latest development version of ggplot2 this way:

pak::pak("tidyverse/ggplot2")

When I run R CMD check I don't see any issues.

R CMD check --run-donttest --as-cran nlmixr2rpt_0.2.1.tar.gz

Can someone tell me the issue with the nlmixr2rpt package and the new version of ggplot2 so I can fix it?

  • 👍1
teunbrand commented

The CRAN tests report this:

Package: nlmixr2rpt
Check: package dependencies
New result: ERROR
Packages required but not available: 'xpose', 'xpose.nlmixr2'
See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.

I recognise this error as a problem upstream with the xpose (or xpose.nlmixr2) package, not necessarily a problem with nlmixr2rpt.
I've sent xpose a PR a while ago, but this may not have made its way to CRAN yet.

john-harrold commented

I know the maintainer for the xpose.nlmxir2 package. I'll reach out to him and see what hes working on/fixed it.

rempsyc commented

Got the email for rempsyc as well. I can reproduce the error with ggplot2 devel version v3.5.2.9002. However, the error originates from qqplotr::stat_qq_band() looking for function check_linewidth(). Using the devel version of qqplotr (v0.0.6.9000) fixes the issue, so I suppose we just need to wait for maintainer @aloy to send it over to CRAN (aloy/qqplotr#20).

  • 👀1