tidyverse/googledrive

Release googledrive 2.1.1

jennybc opened this issue · 2 comments

jennybc commented

Prepare for release:

  • git pull
  • Close v2.1.1 milestone
  • Check current CRAN check results
  • Bump required R version in DESCRIPTION to 3.6
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::build_readme()
  • Remove the dependency on dev gargle
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::cloud_check()
  • Update cran-comments.md
  • git push
  • devtools::build_rmd("index.Rmd")

Submit to CRAN:

  • usethis::use_version('patch')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
jennybc commented

I'm not going to "fix" these until I see if win-builder reports them:

> urlchecker::url_check()
✖ Error: man/drive_endpoints.Rd:33:76 404: Not Found
about the parameters. This list is derived programmatically from the \href{https://www.googleapis.com/discovery/v1/apis/drive/v3/rest}{Drive API v3 Discovery Document} using
                                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
✖ Error: man/request_generate.Rd:40:7 404: Not Found
\href{https://www.googleapis.com/discovery/v1/apis/drive/v3/rest}{Discovery Document}. Most
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

They did get flagged on win-builder so I did "fix" them, i.e. turned them into not-URLs.

jennybc commented

Consider restoring the fake OAuth client temporarily. googlesheets4 will fail revdep check like this otherwise:

*   checking examples ... ERROR
    ```
    Running examples in ‘googlesheets4-Ex.R’ failed
    The error most likely occurred in:
    
    > ### Name: gs4_auth_configure
    > ### Title: Edit and view auth configuration
    > ### Aliases: gs4_auth_configure gs4_api_key gs4_oauth_client
    > 
    > ### ** Examples
    > 
    > # see and store the current user-configured OAuth client (probably `NULL`)
    ...
    > # this example JSON is indicative, but fake
    > path_to_json <- system.file(
    +   "extdata", "data", "client_secret_123.googleusercontent.com.json",
    +   package = "googledrive"
    + )
    > gs4_auth_configure(path = path_to_json)
    Error: parse error: premature EOF
                                           
                         (right here) ------^
    Execution halted
    ```

Alternatively, I guess I could submit googlesheets4, then googledrive? I'll have to think if there's some other reason that that order doesn't work.

Update: I did release googlesheets4 first.