Upkeep for readxl
jennybc opened this issue · 3 comments
Pre-history
-
usethis::use_readme_rmd() -
usethis::use_roxygen_md() -
usethis::use_github_links() -
usethis::use_pkgdown_github_pages() -
usethis::use_tidy_github_labels() -
usethis::use_tidy_style() -
usethis::use_tidy_description() -
urlchecker::url_check()
2020
-
usethis::use_package_doc()
Consider letting usethis manage your@importFromdirectives here.
usethis::use_import_from()is handy for this. -
usethis::use_testthat(3)and upgrade to 3e, testthat 3e vignette - Align the names of
R/files andtest/files for workflow happiness.
usethis::rename_files()can be helpful.
2021
-
usethis::use_tidy_dependencies() -
usethis::use_tidy_github_actions()and update artisanal actions to usesetup-r-dependencies - Remove check environments section from
cran-comments.md -
Bump required R version in DESCRIPTION to 3.4readxl currently does not specify a minimum version for R, so I'm not going to introduce it -
Use lifecycle instead of artisanal deprecation messages, as described in Communicate lifecycle changes in your functionsreadxl doesn't really use artisanal deprecation today. The only deprecated feature is using"blank"instead of"skip"and I think this will naturally resolve when col spec gets modernized.
2022
-
usethis::use_tidy_coc() - Handle and close any still-open
master-->mainissues - Update README badges, instructions in r-lib/usethis#1594
-
Update errors to rlang 1.0.0. Helpful guides:
https://rlang.r-lib.org/reference/topic-error-call.html
https://rlang.r-lib.org/reference/topic-error-chaining.html
https://rlang.r-lib.org/reference/topic-condition-formatting.html
readxl doesn't use rlang (yet) - Update pkgdown site using instructions at https://tidytemplate.tidyverse.org
- Ensure pkgdown
developmentismode: autoin pkgdown config - Re-publish released site; see How to update a released site
The only @importFroms are re: cellranger and that is an area I won't touch until perhaps I decide to inline cellranger.
I should probably rescue the old blog posts I deleted in the commit below and figure out a way to keep them for posterity, without having them render like regular articles in the pkgdown site.
(check if I did same elsewhere, like maybe glue?)
If I did usethis::use_tidy_dependencies(), we'd be able to start using cli, glue, lifecycle, rlang, and withr. Not adding those now, but will be nice to know in the future.
The biggies that are undone are: start using testthat 3d and start using rlang for conditions. So those transitions will be accomplished as makes sense during the natural course of development.