Issues opening in VS Code in beta
mattstauffer opened this issue · 3 comments
@mattstauffer Hmmm, I can't reproduce. Can you tell me how you got this?
Also, I want to move \App\Actions\OpenInEditor to the end of the list of commands...
If the user has configured a terminal editor (nano, vim etc) then Lambo execution will pause until the editor is closed. I could add a method to App\Shell that uses\Symfony\Component\Process\Process->start() which will run asynchronously but then what if it errors. I'd still have to examine the process at some point and decide what to do.
It's easier all around just to open the editor at the end and handle any error that occurs then. Thoughts?
It's easier all around just to open the editor at the end and handle any error that occurs then. Thoughts?
I think in the shell version we opened all editors except terminal editors early (so you can start coding while npm installs). How hard would that be?
Hmmm, I can't reproduce. Can you tell me how you got this?
let me try it again and see 😆
Can't repro. 🤷🏻♂️