Consider whether new updates to the installer would require any changes for us
mattstauffer opened this issue · 2 comments
https://laravel-news.com/laravel-installer-git
I assume no since I don't think we're wrapping the installer anymore, but my kids are screaming right now so I don't have a fully functional brain so I'm just gonna leave this for when I or someone else has a full brain
Currently, we are wrapping the installer but we did agree to remove it since all it does really is wrap composer.
This new feature requires extra flags (--git or --github) and doesn't change the command we run so we should be good here.
Once the Laravel Installer is removed we will not be required to make changes, the question is more like "does it make sense for us to match/replicate this new/changed/removed feature. Does the community expect parity in this instance?"
For what it's worth, I do like this new feature of pushing the new project to GitHub.
OK, sounds good -- thanks! I'm totes OK with us adding it. Will add an issue for it.