What we will do since take_region_error in kvpro have been removed ?

Question

What we will do since take_region_error in kvpro have been removed ?

Closed this issue 3 years ago · 5 comments

inevity commented 3 years ago

https://github.com/tikv/client-rust/blob/master/tikv-client-store/src/errors.rs:32 use the method.

Answer 1 · 2021-12-06T10:23:18.000Z

Where did you find that take_region_error has been removed?

Answer 2 · 2021-12-06T10:35:23.000Z

See master on kvproto, grep return none. this commit 820f463fe509cfe7d2f0ea387f408c1728487834 remove this.

Answer 3 · 2021-12-07T11:12:03.000Z

See master on kvproto, grep return none.

The code is generated when building it. The region_error fields still exist. BTW for backward compatibility fields should be hardly removed.

Answer 4 · 2021-12-08T10:19:47.000Z

The field is still exist, but the method have been removed . I will dig it why this code work

Answer 5 · 2021-12-08T10:32:17.000Z

Just build client-rust and you can see code is generated. It generates methods like get_ take_ has_ for each field.
You might be interested in https://github.com/tikv/protobuf-build

I'm closing it for now. Feel free to open it if you still have questions :).