`refreshModel: true` forces the refresh transition to go in a recursive loop

[neeleshsaxena]

We noticed this problem when we upgraded to v3.8.0 recently. Upon some investigation, I narrowed down the version where this issue was introduced - v3.6.0.

The issue is caused because it loops indefinitely here - https://github.com/tildeio/router.js/blob/master/lib/router/router.ts#L894 and here - https://github.com/tildeio/router.js/blob/master/lib/router/router.ts#L493 causing it to be stuck on refresh transition.

We have a pretty complex app, where we have engines nested inside engine. I have tried to create a replica where I could repro the issue here - https://github.com/neeleshsaxena/emberRouteBug.
Here we have an addon engine, where I'm mounting the addon through the dummy app. The index route performs a transition where it only updates a query param.

I've added screenshots in the repo. Console logs in v3.5.1 vs v3.6.0

Any help/feedback on how to mitigate this issue would be great as it has jacked up our whole application.

Thanks!

[neeleshsaxena]

#284 seems to have fixed this issue.
Updating to ember v3.9.0 resolves the errors and enables model hook again.

Closing this issue.