options.forever doesn't honor delay between retries
m59peacemaker opened this issue · 5 comments
I have a module that depends on this. I just discovered that on forever retries, there is no delay in between the retries. I don't know how to write an appropriate test for this project, but I'm fairly sure it is on this end.
I have just tested this and forever reuses the timeouts array once all of its timeouts have been used up. So I am pretty sure this is a problem in your code.
Do you mind pastebin'ing it?
In my failing case, retries is null, so that would explain it, right?
https://github.com/m59peacemaker/node-try-net-connect/blob/master/index.js
My failing test (just retries instantly) https://github.com/m59peacemaker/node-try-net-connect/blob/master/test/index.js#L75
Submitted a pull request to fix it #33
Merged the PR. Closing this.